On Tue, Apr 12, 2011 at 09:31, Ralf Wildenhues <ralf.wildenh...@gmx.de> wrote: > Hi Janne, > > * Janne Blomqvist wrote on Mon, Apr 11, 2011 at 10:34:58PM CEST: >> the attached patch removes the definition of _GNU_SOURCE from >> AM_CPPFLAGS. This is not needed anymore since nowadays we're calling >> AC_USE_SYSTEM_EXTENSIONS in configure.ac which causes _GNU_SOURCE to >> be defined in config.h. >> >> Regtested on x86_64-unknown-linux-gnu, Ok for trunk? >> >> (I'm not committing this as obvious, though the patch is trivial and >> it seems obvious to me, I still wonder if I'm missing something) > > The patch looks good to me. From > > $ find libgfortran -name \*.c -print \ > | while read f; do grep include.*gfort $f >/dev/null || echo $f; done > ./caf/mpi.c > ./caf/single.c > ./intrinsics/string_intrinsics_inc.c > ./intrinsics/erfc_scaled_inc.c > ./runtime/select_inc.c > ./io/close.c > ./io/inquire.c > ./io/intrinsics.c > ./io/open.c > ./io/size_from_kind.c > ./io/list_read.c > ./io/file_pos.c > ./io/write.c > ./io/lock.c > ./io/unit.c > ./io/transfer.c > ./io/read.c > ./io/transfer128.c > ./io/fbuf.c > ./io/format.c > ./io/unix.c > > it wasn't clear whether all source files actually include config.h, but > > $ for f in $builddir/$target/libgfortran/.deps/*; do > grep config\\.h $f >/dev/null || echo $f > done > > confirms it to be the case. (And anyway that's what you'd fix if not.)
Thanks for the double-check. With that, I think the patch falls under the obvious rule; committed as r172330. -- Janne Blomqvist
