https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81708
--- Comment #19 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Alexandre Oliva <aol...@gcc.gnu.org>: https://gcc.gnu.org/g:4ad200addc3eaf55fba6cc91db3d3b66eabaf3d0 commit r13-2043-g4ad200addc3eaf55fba6cc91db3d3b66eabaf3d0 Author: Alexandre Oliva <ol...@adacore.com> Date: Mon Aug 15 09:21:33 2022 -0300 i386 PIE: testsuite: cope with default pie on ia32 This patch continues the effort of cleaning up the testsuite for --enable-default-pie; the focus herein is mostly 32-bit x86. As much as I tried to avoid it, most of the changes to the testsuite simply disable PIC/PIE, for reasons I'm going to detail below. static-cdtor1.C gets new patterns to match PIE output. Some avx512fp16 tests change only in register allocation, because of the register used to hold the GOT base address. Interrupt tests changed in this regard as well, but here it also affected register saving and restoring. The previous patch modified cet-sjlj tests, mentioning a single regexp covering PIC and nonPIC got incorrect match counts. I found out that adding ?: to parenthesized subpatterns avoids miscounting matches. Other tests that count certain kinds of insns needed adjustment over insns in get_pc_thunk, extra loads from the GOT, or extra adds to compute addresses. In one case, namely stack-check-12, it is nonPIC that had extra insns, that PIC gets rid of, or rather, pushing and popping the PIC register obviates the dummy push and matching pop used for stack probing in nonpic. pr95126 tests were supposed to optimize loads into known constants, but the @GOTOFF addresses prevent that for reasons I have not investigated, but that would be clearly desirable, so I've XFAILed these. pr95852 is another case of missed optimization: sibcalls are not possible when the PIC register needs to be set up for the call, which prevents the expected constant propagation to the return block; I have adjusted the codegen expectations of these tests. As for tests that disable PIE... Some are judgment calls, that fail for similar reasons as tests described above, but I chose not to adjust their expectations; others are just not possible with PIC, or not worth the effort of adjusting. anon[14].C check for no global or comdat symbols, respectively, but -fPIE outputs get_pc_thunk, as global hidden comdat. initlist-const1.C wants .rodata and checks for no .data, but PIC outputs constant data that needs relocations in .data.rel.ro.local. no-stack-protector-attr-3.C and stackprotectexplicit2.C count stack_check_fail matches; -fPIE calls stack_check_fail_local instead, which matches the pattern, but this symbol is also marked as .hidden, so the match count needs to be adjusted. pr71694.C checks for no movl, but get_pc_thunk contains one. pr102892-1.c is a missed optimization, ivopts creates an induction variable because the array address can't be part of an indexing base address with PIE, and that ends up stopping a load from being resolved to a constant as expected. sibcall-11.c needs @PLT for the call, which requires the PIC register, which makes sibcalling impossible. builtin-self.c, in turn, expects no calls, but PIC calls get_pc_thunk. avx* vector tests that had PIE disabled were affected in that the need for GOT-based addressing modes changed instruction selection in ways that deviated from the expectations of the tests. Ditto other vector tests: pr100865*, pr101796-1, pr101846, pr101989-broadcast-1, and pr102021, pr54855-[37], and pr90773-17. pr15184* tests need a PIC register to access global variables, which affects register allocation, so the patterns would have to be adjusted. pr27971 can't use the expected addressing mode to dereference the array with PIC, so it ends up selecting an indexed addressing mode, obviating the expected separate shift insn. pr70263-2 is another case that implicitly expects a sibcall, impossible because of the need for the PIC register; without a sibcall, the expected REG_EQUIV for the reuse of the stack slot of an incoming argument does not occur. pr78035 duplicates the final compare in both then and else blocks with PIE, which deviates from the expected cmp count. pr81736-[57] test for no frame pointer, but the PIC register assignment to a call-saved register forces a frame; the former ends up not using the PIC register, but it's only optimized out after committing to a stack frame to preserve it. pr85620-6 also expects a tail call in a situation that is impossible on ia32 PIC. pr85667-6 doesn't expect the movl in get_pc_thunk. pr93492-5 tests -mfentry, not available with PIC on ia32. pr96539 expects a tail-call, to avoid copying a large-ish struct argument, but the call requires the PIC register, so no tail-call. stack-prot-sym.c expects a nonpic addressing mode. for gcc/testsuite/ChangeLog * g++.dg/abi/anon1.C: Disable pie on ia32. * g++.dg/abi/anon4.C: Likewise. * g++.dg/cpp0x/initlist-const1.C: Likewise. * g++.dg/no-stack-protector-attr-3.C: Likewise. * g++.dg/stackprotectexplicit2.C: Likewise. * g++.dg/pr71694.C: Likewise. * gcc.dg/pr102892-1.c: Likewise. * gcc.dg/sibcall-11.c: Likewise. * gcc.dg/torture/builtin-self.c: Likewise. * gcc.target/i386/avx2-dest-false-dep-for-glc.c: Likewise. * gcc.target/i386/avx512bf16-cvtsbh2ss-1.c: Likewise. * gcc.target/i386/avx512f-broadcast-pr87767-1.c: Likewise. * gcc.target/i386/avx512f-broadcast-pr87767-3.c: Likewise. * gcc.target/i386/avx512f-broadcast-pr87767-5.c: Likewise. * gcc.target/i386/avx512f-broadcast-pr87767-7.c: Likewise. * gcc.target/i386/avx512fp16-broadcast-1.c: Likewise. * gcc.target/i386/avx512fp16-pr101846.c: Likewise. * gcc.target/i386/avx512vl-broadcast-pr87767-1.c: Likewise. * gcc.target/i386/avx512vl-broadcast-pr87767-3.c: Likewise. * gcc.target/i386/avx512vl-broadcast-pr87767-5.c: Likewise. * gcc.target/i386/pr100865-2.c: Likewise. * gcc.target/i386/pr100865-3.c: Likewise. * gcc.target/i386/pr100865-4a.c: Likewise. * gcc.target/i386/pr100865-4b.c: Likewise. * gcc.target/i386/pr100865-5a.c: Likewise. * gcc.target/i386/pr100865-5b.c: Likewise. * gcc.target/i386/pr100865-6a.c: Likewise. * gcc.target/i386/pr100865-6b.c: Likewise. * gcc.target/i386/pr100865-6c.c: Likewise. * gcc.target/i386/pr100865-7b.c: Likewise. * gcc.target/i386/pr101796-1.c: Likewise. * gcc.target/i386/pr101846-2.c: Likewise. * gcc.target/i386/pr101989-broadcast-1.c: Likewise. * gcc.target/i386/pr102021.c: Likewise. * gcc.target/i386/pr90773-17.c: Likewise. * gcc.target/i386/pr54855-3.c: Likewise. * gcc.target/i386/pr54855-7.c: Likewise. * gcc.target/i386/pr15184-1.c: Likewise. * gcc.target/i386/pr15184-2.c: Likewise. * gcc.target/i386/pr27971.c: Likewise. * gcc.target/i386/pr70263-2.c: Likewise. * gcc.target/i386/pr78035.c: Likewise. * gcc.target/i386/pr81736-5.c: Likewise. * gcc.target/i386/pr81736-7.c: Likewise. * gcc.target/i386/pr85620-6.c: Likewise. * gcc.target/i386/pr85667-6.c: Likewise. * gcc.target/i386/pr93492-5.c: Likewise. * gcc.target/i386/pr96539.c: Likewise. PR target/81708 (%gs:my_guard) * gcc.target/i386/stack-prot-sym.c: Likewise. * g++.dg/init/static-cdtor1.C: Add alternate patterns for PIC. * gcc.target/i386/avx512fp16-vcvtsh2si-1a.c: Extend patterns for PIC/PIE register allocation. * gcc.target/i386/pr100704-3.c: Likewise. * gcc.target/i386/avx512fp16-vcvtsh2usi-1a.c: Likewise. * gcc.target/i386/avx512fp16-vcvttsh2si-1a.c: Likewise. * gcc.target/i386/avx512fp16-vcvttsh2usi-1a.c: Likewise. * gcc.target/i386/avx512fp16-vmovsh-1a.c: Likewise. * gcc.target/i386/interrupt-11.c: Likewise, allowing for preservation of the PIC register. * gcc.target/i386/interrupt-12.c: Likewise. * gcc.target/i386/interrupt-13.c: Likewise. * gcc.target/i386/interrupt-15.c: Likewise. * gcc.target/i386/interrupt-16.c: Likewise. * gcc.target/i386/interrupt-17.c: Likewise. * gcc.target/i386/interrupt-8.c: Likewise. * gcc.target/i386/cet-sjlj-6a.c: Combine patterns from previous change. * gcc.target/i386/cet-sjlj-6b.c: Likewise. * gcc.target/i386/pad-10.c: Accept insns in get_pc_thunk. * gcc.target/i386/pr70321.c: Likewise. * gcc.target/i386/pr81563.c: Likewise. * gcc.target/i386/pr84278.c: Likewise. * gcc.target/i386/pr90773-2.c: Likewise, plus extra loads from the GOT. * gcc.target/i386/pr90773-3.c: Likewise. * gcc.target/i386/pr94913-2.c: Accept additional PIC insns. * gcc.target/i386/stack-check-17.c: Likewise. * gcc.target/i386/stack-check-12.c: Do not require dummy stack probing obviated with PIC. * gcc.target/i386/pr95126-m32-1.c: Expect missed optimization with PIC. * gcc.target/i386/pr95126-m32-2.c: Likewise. * gcc.target/i386/pr95852-2.c: Accept different optimization with PIC. * gcc.target/i386/pr95852-4.c: Likewise.
