https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89432

--- Comment #10 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
(In reply to Uroš Bizjak from comment #8)
> (In reply to ibuclaw from comment #6)
> > Author: ibuclaw
> > Date: Wed Apr 24 18:57:36 2019
> > New Revision: 270554
> > 
> > URL: https://gcc.gnu.org/viewcvs?rev=270554&root=gcc&view=rev
> > Log:
> > libphobos: Fix FAIL phobos.exp/core.time on CentOS 5.11, Linux 2.6.18
> > 
> > Merges upstream druntime e03164b5.
> > 
> > Reviewed-on: https://github.com/dlang/druntime/pull/2581
> > 
> > libphobos/ChangeLog:
> > 
> > 2019-04-24  Iain Buclaw  <ibuc...@gdcproject.org>
> > 
> >     PR d/89432
> >     * testsuite/lib/libphobos.exp (check_effective_target_linux_pre_2639):
> >     New proc.
> >     * testsuite/libphobos.druntime/druntime.exp: Add compiler flag
> >     -fversion=Linux_Pre_2639 if target is linux_pre_2639.
> >     * testsuite/libphobos.druntime_shared/druntime_shared.exp: Likewise.
> > 
> > Modified:
> >     trunk/libphobos/ChangeLog
> >     trunk/libphobos/libdruntime/MERGE
> >     trunk/libphobos/libdruntime/core/time.d
> >     trunk/libphobos/testsuite/lib/libphobos.exp
> >     trunk/libphobos/testsuite/libphobos.druntime/druntime.exp
> >     trunk/libphobos/testsuite/libphobos.druntime_shared/druntime_shared.exp
> 
> This part:
> 
> #include <linux/version.h>
> #if !defined LINUX_VERSION_CODE || LINUX_VERSION_CODE <
> KERNEL_VERSION(2.6.39)
> #error Yes, it is.
> #endif
> 
> The KERNEL_VERSION macro expects three arguments, so commas should be used:
> 
> "KERNEL_VERSION(2,6,39)"
> 

Oops, that must have been a fat finger incident when I was switching between
2,6,39 and 4,19,0 to test the trigger.

Reply via email to