http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46823

--- Comment #21 from Jan Hubicka <hubicka at ucw dot cz> 2011-01-13 16:49:42 
UTC ---
> Err - I'm not sure what this
> 
>   /* Turn forward declarations into real ones.  */
>   fn = cgraph_node (fn)->decl;
> 
> is about at all.  At least the comment doesn't make any sense to me.

It is remainder from the times when we didn't have one decl rule. But these
days it still translates same body alises into the functions.

Actually in my comment in #17, I was not concernerned about edge pointing to
an alias, I was concerned about cgraph_redirect_edge_call_stmt_to_callee
possibly not happening before inlining.  This seems all fine.

Direct calls to same body aliases are OK and I agree with Jakub that we should
not redirect them to the actual function just for fun.

So the patch #16 is OK.
Thanks and sorry for confussion above.
Honza

Reply via email to