------- Comment #9 from felix-gcc at fefe dot de 2007-01-17 13:55 -------
Hey Andrew, do you really think this issue goes away if you keep closing the
bugs fast enough?
Let me tell you something: that INT_MAX way to do it is bogus. These checks
are there so that it is obvious the int overflow is caught and handled. If you
use INT_MAX, then the auditor still has to check if it was an int and not an
unsigned int, for example.
If that doesn't convince you, let's say it's not int, but it's "ptrdiff_t". Or
"off_t". Or "beancount_t", which the application defined somewhere. Then
limits.h won't have a _MAX definition for it. What if the size of the type
depends on the context as well? There are multiple definitions of it depending
on some -Dwhatever on the command line?
All these cases were covered just fine by the "if (a+100 < a)" check. There is
no context needed about the type of a, it works for pointers, unsigned
integers, and signed integers. Well, you broke the pointer bit once, too, but
that was reverted. The guy who reverted it back then should come back, we need
someone with his vision and good judgement here now.
No, let's face it. You fucked this up royally, and now you are trying to close
all the bugs as fast as you can, so nobody sees just how much damage you have
done. You, sir, are unprofessional and a disgrace to the gcc development team.
And this bug stays open until you revert the change or make it opt-in instead
of opt-out. As long as you just destroy programs where the author foolishly
opted in, I don't care. But I will not let you make my work environment less
secure because you don't have the professionalism to let your pet optimization
go, after it was shown to do more damage than good. How much more proof do you
need? For god's sake, autoconf considers turning your "optimization" off
globally! Do you even notice all the explosions around you?
PS: Mr Simon, that link to a how-to that says "btw this doesn't work for this
special input", is that supposed to impress anyone? It certainly does not
impress me very much, really.
It's better to keep your mouth shut and appear stupid than to
open it and remove all doubt.
--Mark Twain (1835 - 1910)
--
felix-gcc at fefe dot de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |UNCONFIRMED
Resolution|DUPLICATE |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30475
