On Thu, 07 Sep 2017 14:50:32 +0000 David Lewis <[email protected]> wrote: > Can you review the open pull requests and if they look good let me know so > I can merge them?
I am a bit backlogged ATM, but did have a quick look the other day. There were several issues with the gifts one, but the real showstopper there is that we need to work out reasonable values for the magic numbers. I agree ATM the price/50 value is too low, but I suspect price * 40% goes the other way. It is not too hard to to sell a high value cargo for 1000 gold (I just tried with a starting game and 100 Trade Goods and got an initial offer of 1064 from the Arawak), so that is a change of around -400 alarm. The *entire* meaningful range of alarm is from HAPPY(100) to HATEFUL(1000) (see Tension.Level), so all it would require is 2 big trades to go from near war (ANGRY(800)) down to happy again. That seems too fast to me. My suggestion is values of 10%/10%/15%, but admit I (semi-)pulled these numbers out of the air (100 is the minimum alarm distance between named levels), and thus would really like some rationale, or even better, actual Col1 measurements to base this on. The deSoto one is fine and does the job. Thanks for following this up. However looking at it reminded me just what a mess LCR.chooseType is:-P. Feel free to commit, but I am seriously tempted to rewrite the whole routine for clarity. Should have some time over the weekend to catch up. Playtesting has thrown up a few weird things I need to follow through on, notably I am unhappy with the fix for BR#3083. Cheers, Mike Pope
pgpH5idzaACm_.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
