On Thu, 31 Aug 2017 17:30:15 +0000 David Lewis <[email protected]> wrote: > Yeah, the tests need a lot of love. I enabled the simpleMove test purely > for the sake of using the client helper tests. Although those should be > their own tests, I am still learning the system, so haven't created a > client test yet.
I am unconvinced that is going to provide much benefit. The client code is likely to be race-prone, and thus difficult to make stable tests for. The fact that we have only one (previously disabled) client test was likely for good reason. OTOH there are many critical routines that would benefit from small scale unit tests that require neither client or server processes... lots of low hanging fruit that would really improve the test suite coverage. > At the moment I'm cleaning up and fixing the build.xml file (creating a new > one for the time being) that will be designed to create packages from > Travis and be deployed automatically so we don't have to do any of that > manually. I am wary of adding travis as a build dependency. I am sure it is very nice, but adding another step in the learning curve needs some justification. Automatic package addition is not particularly convincing. Adding packages is *very* rare. I think I have done it once. > There are a number of dependency issues that need to be solved > before distributions can be made. I've figured out most of the errors, and > now just a matter of cleaning things up. There are a lot of legacy settings > in there. Not sure what you have hit here. Can you give an example? > Travis is currently only failing on 2 tests, it can't find the sound mixer. > Likely because it's a container. Looks like it to me. The SoundPlayer code is not very resilient. Feel free to rework either it or the tests. I would be inclined to just disable sound tests if AudioSystem.getMixerInfo returns no signs of a mixer being present. Cheers, Mike Pope
pgpfOwcRAikgX.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
