BR#2643 is a new interesting fail following the role changes. The game contains a REF unit that is an armed FreeColonist. The REF has captured a large city, and it looks like the AI is now smart enough to arm loose units and use them against the pesky rebels, which I think is fair enough. The trouble is that armed REF units have the "infantry" role, so the resource lookup for a suitable image is failing (we have:
model.unit.freeColonist.image=resources/images/units/freeColonist.png ... model.unit.freeColonist.soldier.image=resources/images/units/soldier/soldier.png ... model.unit.kingsRegular.image=resources/images/units/kingsRegular.png ... model.unit.kingsRegular.infantry.image=resources/images/units/infantry/kingsRegular.png ...but not "model.unit.freeColonist.infantry.image"). The bug reporter is playing from trunk, so I do not want to see him blocked by something where there is a simple workaround, so I have committed the obvious quick-and-dirty solution of adding "infanty" and "cavalry" resources for the ordinary units (git.abefb2d). However this does not strike me as the Right Thing. What is the Right Thing? Try alternate roles if resource lookup fails? Do not use "infantry" for non-KingsRegulars? Cheers, Mike Pope
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
