> In message <[EMAIL PROTECTED]> "David O'Brien" writes:
> : On Tue, Nov 23, 1999 at 09:15:35PM -0800, Kris Kennaway wrote:
> : > - (void)fgets(message, sizeof(message), stdin);
> : > + (void)fgets(message, MAXMSG, stdin);
> :
> : There is nothing wrong with the original line here. Please don't change
> : things that are fine just to change them. We don't want to ofuscate the fix.
>
> In fact, the original line is safer than the replaced line. It is
> safer because message's size might change form MAXMSG to MAXBUF or 24.
> If you hardwire MAXMSG like this, painful experience has shown that
> you will get burned.
Well the original line is plain wrong if Brian's patch is being used,
because there message is a pointer and the size of a pointer is 4.
John
--
John Hay -- [EMAIL PROTECTED]
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
