j...@resonance.org skrev: > There is no rule currently in regards to max lengths of files. I think > if a file gets relatively large (1500 lines or so) and there is a pretty > clear logical division that can be made, then splitting it would be > good. I have also been thinking that source directories might be > helpful for organizing the code. At a minimum a separate directory for > all driver related source files, since it can be difficult to > differentiate between those and core synthesis files if one is not > familiar with the project. There aren't a huge amount of files though, > so we can probably just let it be for now.
A "audiodriver" and a "mididriver" folder sounds good to me. That means we have to split fluid_alsa.c, but that should be a piece of cake. >> Another thing is max columns per line. Do we keep it at 76/80 chars and >> then a new line, or how long lines do we allow? > I think it is good to keep it around max 80 chars, but some overflow is > OK. #define some_overflow 20 #define total_line_length (80+some_overflow) > If code starts getting crammed up against the right side, it > probably means the code could use some redesign. Either that, or shorter function names... ;-) > I was planning on auto-indenting the whole lot and manually going > through and correcting problem areas. That is why I was mentioning it > would be good to get it out of the way now, early in this development > cycle. To minimize the amount of functional changes that have occurred > before the re-formatting point. Ok. To me, I don't mind to keep the existing code as it is, but if you don't mess it up too much, feel free to go ahead and auto-indent it. :-) I think I can read both equally well. // David _______________________________________________ fluid-dev mailing list fluid-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/fluid-dev
