Hi, On 10.01.2018 16:20, R. Diez via flashrom wrote: > Hi all: > > The behaviour of option --image has changed between versions 0.9.9 and > 1.0.0.
thanks for noting. It has changed indeed, the old behaviour wasn't quite safe, imho. > > In the past, I wasn't specifying any --image, and flashrom just flashed > the one and only that I had defined in my layout file. That's not accurate. If you didn't specify any --image to include, it just ignored the layout. Which unlikely was the intention if one speci- fied a layout in the first place. > > Now, flashrom just states that the chip content is identical, which is > not the case. This is the output: > > --------8<--------8<--------8<-------- > flashrom v1.0 on Windows 6.1 (x86) > flashrom is free software, get the source code at https://flashrom.org > > Calibrating delay loop... OK. > Found Macronix flash chip "MX25L6406E/MX25L6408E" (8192 kB, SPI) on > ft2232_spi. > Reading old flash chip contents... done. > Erasing and writing flash chip... > Warning: Chip content is identical to the requested image. > Erase/write done. > --------8<--------8<--------8<-------- > > That is misleading. If the newer flashrom does not default to any image > (or maybe to all images?), and the user specifies a layout file but not > --image arguments, it should then fail with "no layout image specified" > or a similar error message. Right, this was overlooked so far. Or maybe I thought the warning might be enough to show the user that something is fishy. We are currently reworking the --image parameters. Such a message should be added. I'm not sure about failing (i.e. returning an error code), though. Technically, not writing anything when no --image arguments are given seems correct. Nico _______________________________________________ flashrom mailing list [email protected] https://mail.coreboot.org/mailman/listinfo/flashrom
