Alon Bar-Lev has posted comments on this change.
Change subject: pki: Cleanup CA creation
......................................................................
Patch Set 9:
(2 comments)
....................................................
File packaging/bin/pki-common.sh.in
Line 15: while [ -n "$1" ]; do
Line 16: local f="$1"
Line 17: shift
Line 18: [ -f "${f}" ] && cp -a "${f}" "${f}.${time}" || \
Line 19: die "Failed to backup ${f}"
are you sure this statement will not die if file is missing?
it should be:
if [ -f .. ]; then
cp -a || die
fi
or (not that I like):
[ -f ... ] && { cp -a || die }
Line 20: done
Line 21: }
Line 22:
Line 23: common_restore_perms() {
....................................................
File packaging/bin/pki-create-ca.sh
Line 1
Line 2
Line 3
Line 4
Line 5
move config after clean?
--
To view, visit http://gerrit.ovirt.org/18749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibab2884b461da0a723ea9d2040985a2429af1632
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
