Sandro Bonazzola has posted comments on this change. Change subject: Add new --output option. ......................................................................
Patch Set 2: Code-Review-1 (2 comments) Also please verify. .................................................... File src/__main__.py Line 1269: ) Line 1270: Line 1271: parser.add_option( Line 1272: "", "--local-tmp", dest="local_tmp_dir", Line 1273: help="directory to copy reports to locally " I don't think that this work without enclosing all the strings in ( ). Line 1274: "Please note that the local-tmp directory is used " Line 1275: "only for storing temporary reports gathered from hypervisors." Line 1276: "(default is randomly generated like: %s)" % DEFAULT_SCRATCH_DIR, Line 1277: metavar="PATH", Line 1327: Line 1328: parser.add_option( Line 1329: "", "--output", dest="output", Line 1330: help="Destination directory where the report will be stored", Line 1331: default=tempfile.gettempdir() please use spaces instead of tabs. Line 1332: ) Line 1333: Line 1334: engine_group = OptionGroup( Line 1335: parser, -- To view, visit http://gerrit.ovirt.org/18781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba8ec7c6d65901158ede692f0ba51c07178298d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
