Sandro Bonazzola has posted comments on this change.
Change subject: Add new --output option.
......................................................................
Patch Set 1:
(3 comments)
....................................................
File src/__main__.py
Line 894: print _('Creating compressed archive...')
Line 895: report_file_ext = 'bz2'
Line 896: compressor = 'bzip2'
Line 897: caller = Caller({})
Line 898: output_dir = tempfile.gettempdir()
move this to the default in option parser
Line 899: try:
Line 900: caller.call('xz --version')
Line 901: report_file_ext = 'xz'
Line 902: compressor = 'xz'
Line 902: compressor = 'xz'
Line 903: except Exception:
Line 904: logging.debug('xz compression not available')
Line 905:
Line 906: if self.conf["output"]:
if it's defined as default it always exists so you can skip this check
Line 907: output_dir = self.conf["output"]
Line 908: if not os.path.exists(output_dir):
Line 909: os.makedirs(output_dir)
Line 910:
Line 1329: )
Line 1330:
Line 1331: parser.add_option(
Line 1332: "", "--output", dest="output",
Line 1333: help="Destination directory where the report will be stored"
default=tempfile.gettempdir()
Line 1334: )
Line 1335:
Line 1336: engine_group = OptionGroup(
Line 1337: parser,
--
To view, visit http://gerrit.ovirt.org/18781
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba8ec7c6d65901158ede692f0ba51c07178298d9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
