Noam Slomianko has posted comments on this change. Change subject: failing plugin should cause an exception ......................................................................
Patch Set 1: Throwing an exception means not returning any results. As far as I understood from doron this should be a "best effort" code, returning the best results available. this patch[1] creates better logging instead. [1] http://gerrit.ovirt.org/#/c/18789/ -- To view, visit http://gerrit.ovirt.org/18788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0312ae89a08dde5697d9ea822af1eb1b80ad4e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
