Laszlo Hornyak has uploaded a new change for review.
Change subject: failing plugin should cause an exception
......................................................................
failing plugin should cause an exception
Changes the aggregation so that if a plugin is failing, an exception is
returned to the client rather than an empty list
Change-Id: Ib0312ae89a08dde5697d9ea822af1eb1b80ad4e0
Signed-off-by: Laszlo Hornyak <lhorn...@redhat.com>
---
M src/ovirtscheduler/request_handler.py
M src/ovirtscheduler/request_handler_test.py
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-scheduler-proxy
refs/changes/88/18788/1
diff --git a/src/ovirtscheduler/request_handler.py
b/src/ovirtscheduler/request_handler.py
index dd5a50b..97dd855 100644
--- a/src/ovirtscheduler/request_handler.py
+++ b/src/ovirtscheduler/request_handler.py
@@ -112,6 +112,10 @@
def aggregate_filter_results(self, filterRunners):
resultSet = set()
for runner in filterRunners:
+ if runner.getErrors():
+ self._logger.warn('Error in %s', runner._script)
+ raise RuntimeError("plugin throw exception found: "
+ +runner._script)
if runner.getResults() is None:
self._logger.warn('No results from %s', runner._script)
continue
diff --git a/src/ovirtscheduler/request_handler_test.py
b/src/ovirtscheduler/request_handler_test.py
index cd70b64..7e50f0a 100644
--- a/src/ovirtscheduler/request_handler_test.py
+++ b/src/ovirtscheduler/request_handler_test.py
@@ -72,5 +72,8 @@
def getResults(self):
return None
+ def getErrors(self):
+ return None
+
filterRunners = [NoneResultRunner()]
assert executor.aggregate_filter_results(filterRunners) is not None
--
To view, visit http://gerrit.ovirt.org/18788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0312ae89a08dde5697d9ea822af1eb1b80ad4e0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
