Sahina Bose has posted comments on this change. Change subject: restapi: Modified gluster volume rebalance action ......................................................................
Patch Set 5: @Ori, > 1) I don't understand the motivation for the rename > rebalance-->startrebalance. I think rebalance is a better name. Is it for > consistency with GUI? From API point of view this is not an acceptable > argument; we want the clearest, friendliest API, regardless of how things are > in the GUI. The underlying rebalance operation in gluster is an asynchronous operation and returns a gluster task id. The rebalance operation once started can be stopped, as well as queried for status. See http://www.ovirt.org/Features/Detailed_Gluster_Volume_Asynchronous_Tasks_Management#REST_API. If we continue calling the action rebalance, need suggestions on how we can model the stop and status > 3) Could you please elaborate about task-id? IIUC it's meant for > task-monitoring, and we recently had infrastructure added for task-monitoring > of 3rd parties by Eli Mesika, and that infrastructure should be used, if > there's no good reason not to. Task id in this case is a gluster task id. Eli's change allows for external task monitoring, whereas here the gluster task will be treated as internal task similar to vdsm task albeit managed by gluster. -- To view, visit http://gerrit.ovirt.org/18208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9fd560cc1b6a0db9cc28647bc311cb9f1b9e3b3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
