Ori Liel has posted comments on this change. Change subject: restapi: Modified gluster volume rebalance action ......................................................................
Patch Set 5: 1) About rebalance-->startrebalance: all existing engine actions may be invoked asynchronously by the API, in which case they run in the background until completed. We didn't see this as a reason to give them all 'start' prefixes. So now 'startrebalance' will be an exceptional case, and we obviously prefer consistency. I would simply leave the name as it is. I'm interested to know what Michael thinks as well. 2) You did not reply about my comment that this change would break existing API: if someone has a script that activates 'rebalance' this script will cease to work. When was this feature originally released? Can we guarantee that we're not breaking customer scripts? 3) Ideally, we (meaning Engine) would supply infrastructure for stop/resume of jobs and querying detailed status for a job, and you would be a client of that infrastructure. We already have the concept of 'job' in the Engine, but right now we lack these abilities. Since that's the situation, it's OK by me that you manage it yourself, although it means that in the future we will maintain two separate task-handling logics. -- To view, visit http://gerrit.ovirt.org/18208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9fd560cc1b6a0db9cc28647bc311cb9f1b9e3b3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
