Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Fix popups after engine restart & relogin
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TabModelProvider.java
Line 144: UICommand lastExecutedCommand =
model.getLastExecutedCommand();
Line 145: if (lastExecutedCommand != null &&
!lastExecutedCommand.getIsCancel()) {
Line 146: // Refresh the grid using ForceRefresh command
Line 147: SearchableListModel searchableList =
(SearchableListModel) model;
Line 148: searchableList.getForceRefreshCommand().execute();
for readability/consistency, consider invoking SearchableListModel ->
forceRefresh() instead...
Line 149: }
Line 150: }
Line 151: }
Line 152:
--
To view, visit http://gerrit.ovirt.org/18729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd934c9ec6129b0b45224ddb08a5c41b070a60bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
