Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Fix popups after engine restart & relogin ......................................................................
Patch Set 1: -Verified In case of auto-logout due to engine restart, ApplicationPlaceManager reveals login section place (#login) without closing any popups that might have been open before auto-logout. As a result, RootPresenter's popupChildren list still contains popups that were not closed properly before auto-logout. In other words, RootPresenter still thinks such popups are open. For non-singleton popups - new PresenterWidget/View instance created upon each reveal: * not a big deal, new popups can still be revealed, however RootPresenter's popupChildren list will get polluted after each auto-logout * i.e. all popups bound to UiCommon models For singleton popups - one PresenterWidget/View instance created/reused upon each reveal: * such popup cannot be revealed again once RootPresenter's popupChildren list contains its reference after auto-logout * i.e. generic error popup, used to display application errors I'll try to fix this issue for both non-singleton and singleton popups, clearing verified flag for now. -- To view, visit http://gerrit.ovirt.org/18729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd934c9ec6129b0b45224ddb08a5c41b070a60bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
