Kanagaraj M has posted comments on this change.
Change subject: webadmin: [WIP] gluster volume rebalance status popup
......................................................................
Patch Set 15:
(8 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
Line 992: else if (StringHelper.stringsEqual(command.getName(),
"Cancel")) //$NON-NLS-1$
Line 993: {
Line 994: cancel();
Line 995: }
Line 996: }
Please remove this file from the commit.
Line 997: /**
Line 998: * Splits a search string into two component, the prefix and a
search string itself.
Line 999: */
Line 1000: private void splitSearchString(String source, RefObject<String>
prefix, RefObject<String> search)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeRebalanceStatusModel.java
Line 113: case FAILED:
Line 114: case ABORTED:
Line 115: break;
Line 116: default :
Line 117: refresh.scheduleRepeating(8000);
This should be schedule instead of scheduleRepeating
Line 118: }
Line 119: }
Line 120: }),
Line 121: entity.getClusterId(),
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 3229: @DefaultStringValue("Cluster")
Line 3230: String rebalanceClusterVolume();
Line 3231:
Line 3232: @DefaultStringValue("Stop")
Line 3233: String rebalanceStopVolume();
If this is not used, please remove it.
Line 3234:
Line 3235: //Volume Rebalance Status Table Columns
Line 3236: @DefaultStringValue("Host")
Line 3237: String rebalanceSessionHost();
Line 3264: @DefaultStringValue(",")
Line 3265: String getComma();
Line 3266:
Line 3267: @DefaultStringValue(":")
Line 3268: String getColon();
Please remove this section if you are not using
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
Line 114:
entity.setTotalSizeMoved(bytesToKbs(entity.getTotalSizeMoved()));
Line 115: return entity.getTotalSizeMoved() + " kb";
//$NON-NLS-1$
Line 116: }else {
Line 117: return entity.getTotalSizeMoved() + " bytes";
//$NON-NLS-1$
Line 118: }
Consider using ApplicationMessages, if you want the dynamic messages to be
translated
Line 119: }
Line 120: }, constants.rebalanceSize());
Line 121:
Line 122: rebalanceHostsTable.addEntityModelColumn(new
EntityModelTextColumn<GlusterVolumeTaskStatusForHost>() {
Line 182: }
Line 183:
Line 184: public long bytesToGbs(long bytes) {
Line 185: return bytesToMbs(bytes)/1024;
Line 186: }
Please move this conversions to a utility class
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.ui.xml
Line 40: <g:Label ui:field="messageLabel"
addStyleNames="{style.messageLabel}" />
Line 41: </g:VerticalPanel>
Line 42: </d:content>
Line 43: </d:SimpleDialogPanel>
Line 44:
Please remove the spaces
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml
Line 15: <set-property name="gwt.logging.logLevel" value="INFO" />
Line 16: <set-property name="gwt.logging.popupHandler" value="DISABLED"
/>
Line 17:
Line 18: <!-- Supported browsers (defined via maven property) -->
Line 19: <set-property name="user.agent" value="gecko1_8"/>
This change should not be part of this commit
Line 20:
Line 21: <!-- GWTP GIN configuration -->
Line 22: <set-configuration-property name="gin.ginjector.modules"
value="org.ovirt.engine.ui.webadmin.gin.ClientModule" />
Line 23: <set-configuration-property name="gin.ginjector.extensions"
value="org.ovirt.engine.ui.webadmin.gin.ClientGinjectorExtension" />
--
To view, visit http://gerrit.ovirt.org/18328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1f63b21dfbed88fa2b4e8c077e3e5e54ba7b09
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
