Alexander Wels has posted comments on this change. Change subject: UI: expose CSS class defined in LoginPopupView.ui.xml ......................................................................
Patch Set 1: In principle we are not opposed to exposing CSS classes in external CSS files after all that is why we created the whole branding mechanism. We also expected that once people are able to do limited branding they would want to expand what is brand-able. On the other hand we want to define an API where people can know and understand what is brand-able and what is not. So we decided to put obrand_ in front of all brand-able class names. We also don't want to expose all CSS classes in *.ui.xml by default as there are a lot of advantages of having the classes compiled into the javascript. One of them being that at runtime we don't need extra round trips to the server to collect the styles.So we took the approach of having a small set of brand-able classes, with the knowledge we will expand it over time to include more classes as people find a need to brand them. So in short, please put obrand_ in front of all the classes you want to expose and put the exposed classes in packaging/branding/ovirt.brand/common.css (which you already did, just change the name and put some comments in the css file so people know where it belongs) -- To view, visit http://gerrit.ovirt.org/18156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80dcacf8d62f9bb051747e530f0d24e692388ce7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: 静 黎 <mobi...@gmail.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: 静 黎 <mobi...@gmail.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
