Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: Added app_mode field to roles table
......................................................................


Patch Set 7:

(1 comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
Line 45:         result = prime * result + ((description == null) ? 0 : 
description.hashCode());
Line 46:         result = prime * result + (readOnly ? 1231 : 1237);
Line 47:         result = prime * result + ((name == null) ? 0 : 
name.hashCode());
Line 48:         result = prime * result + ((type == null) ? 0 : 
type.hashCode());
Line 49:         result = prime * result + ((appMode == null) ? 
ApplicationMode.VirtOnly.getValue() : appMode.getValue());
As discussed in case appMode is null will use 0
Line 50:         return result;
Line 51:     }
Line 52: 
Line 53:     @Override


-- 
To view, visit http://gerrit.ovirt.org/18592
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id83b7a2c90100744487b276642158e7c3e93de85
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to