Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Added app_mode field to roles table
......................................................................
Patch Set 7:
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
Line 33:
Line 34: private ApplicationMode appMode;
Line 35:
Line 36: public Role() {
Line 37: id = Guid.Empty;
Will do this
Line 38: }
Line 39:
Line 40: @Override
Line 41: public int hashCode() {
Line 45: result = prime * result + ((description == null) ? 0 :
description.hashCode());
Line 46: result = prime * result + (readOnly ? 1231 : 1237);
Line 47: result = prime * result + ((name == null) ? 0 :
name.hashCode());
Line 48: result = prime * result + ((type == null) ? 0 :
type.hashCode());
Line 49: result = prime * result + ((appMode == null) ?
ApplicationMode.VirtOnly.getValue() : appMode.getValue());
I feel it should be set to All if null. Will do the changes.
Line 50: return result;
Line 51: }
Line 52:
Line 53: @Override
....................................................
File packaging/dbscripts/upgrade/03_03_0800_add_app_mode_to_roles.sql
Line 1: -- Adding app_mode column to roles table to store the application mode.
Line 2: -- The value of application modes for a role decides if that role is
available in that application mode.
Done
Line 3: -- The value of application mode is represented by a unique binary
number. Value of newer modes should be a power of 2.
Line 4: -- Current valid values of application modes are -
Line 5: -- VirtOnly - 0000 0001
Line 6: -- GlusterOnly - 0000 0010
--
To view, visit http://gerrit.ovirt.org/18592
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id83b7a2c90100744487b276642158e7c3e93de85
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
