Shubhendu Tripathi has posted comments on this change.
Change subject: gluster:VDS command to get gluster tasks list
......................................................................
Patch Set 4:
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTask.java
Line 5: import org.ovirt.engine.core.common.job.JobExecutionStatus;
Line 6: import org.ovirt.engine.core.common.utils.ObjectUtils;
Line 7: import org.ovirt.engine.core.compat.Guid;
Line 8:
Line 9: public class GlusterAsyncTask implements Serializable{
We can think of adding a base class with name AsyncTask as AsyncTask<P extends
AsyncTaskParameters> and async task classes like SPMAsyncTask and
GlusterAsyncTask can extend from the same.
Similarly AsyncTaskParameters can work as base class for GlusterTaskParameters
Line 10:
Line 11: private static final long serialVersionUID = 5165089908032934194L;
Line 12:
Line 13: private Guid taskId;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterTaskParameters.java
Line 1: package org.ovirt.engine.core.common.asynctasks.gluster;
Line 2:
Line 3: import java.io.Serializable;
Line 4:
Line 5: public class GlusterTaskParameters implements Serializable{
This class can extend from AsyncTaskParameters. Check if valid.
Line 6:
Line 7: private static final long serialVersionUID = 7151931460799410911L;
Line 8: private String volumeName;
Line 9: private String[] bricks;
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterTasksListReturnForXmlRpc.java
Line 22: private static final String VOLUME_NAME = "volume";
Line 23: private static final String FILES_MOVED = "filesMoved";
Line 24: private static final String TOTAL_SIZE_MOVED = "totalSizeMoved";
Line 25: private static final String FILES_SCANNED = "filesScanned";
Line 26: private static final String FILES_FAILED = "filesFailed";
Do we have fileSkipped as valid field here as well like we have in volume
rebalance status?
Line 27:
Line 28: private List<GlusterAsyncTask> tasks = new
ArrayList<GlusterAsyncTask>();
Line 29:
Line 30: @SuppressWarnings("unchecked")
--
To view, visit http://gerrit.ovirt.org/15972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bf9c1075cd7b27adcbbff8d71de183f40a02eea
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
