Allon Mureinik has posted comments on this change. Change subject: core: rename methods to start with lowercase ......................................................................
Patch Set 2: you are grouping unrelated FB issues together. This is a surefire way to make backporting/cherry-picking harder. Again - I'm a fan of all the changes (hence +1), but I think the correct way to do this is in smaller, self-explanatory patches. Flagging +1, and leaving it to the other reviewers to decide. -- To view, visit http://gerrit.ovirt.org/18546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3d77789be17e90f63c734dba3365c0178326029 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
