Doron Fediuck has posted comments on this change.
Change subject: engine: test for ExternalSchedulerDiscoveryThread
......................................................................
Patch Set 3:
(1 comment)
See inline.
This may fail CI.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThreadTest.java
Line 22: import org.ovirt.engine.core.compat.Guid;
Line 23: import org.ovirt.engine.core.dao.scheduling.PolicyUnitDao;
Line 24: import org.ovirt.engine.core.utils.MockConfigRule;
Line 25:
Line 26: public class ExternalSchedulerDiscoveryThreadTest {
You need to dynamically choose the port, as multiple tests may be running
in Jenkins at the same time.
This is relevant for other patches as well.
Line 27: final static private int testPort = 12345;
Line 28: private static WebServer server;
Line 29:
Line 30: @Rule
--
To view, visit http://gerrit.ovirt.org/18333
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I616f4063847686c6bab2366b57030f68ac80b73c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
