Laszlo Hornyak has posted comments on this change.
Change subject: engine: test for ExternalSchedulerDiscoveryThread
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
Line 59:
Line 60: reloadPolicyUnits();
Line 61: }
Line 62:
Line 63: void reloadPolicyUnits() {
package protected
Line 64: SchedulingManager.getInstance().reloadPolicyUnits();
Line 65: }
Line 66:
Line 67: private void markExternalPoliciesAsDisabled(List<PolicyUnit>
units) {
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThreadTest.java
Line 22: import org.ovirt.engine.core.compat.Guid;
Line 23: import org.ovirt.engine.core.dao.scheduling.PolicyUnitDao;
Line 24: import org.ovirt.engine.core.utils.MockConfigRule;
Line 25:
Line 26: public class ExternalSchedulerDiscoveryThreadTest {
I see no reason why not, it does the same as the python thing and in this way
we can also make sure that the TCP interactions really happen when expected.
Line 27: final static private int testPort = 12345;
Line 28: private static WebServer server;
Line 29:
Line 30: @Rule
--
To view, visit http://gerrit.ovirt.org/18333
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I616f4063847686c6bab2366b57030f68ac80b73c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
