Yaniv Bronhaim has posted comments on this change.
Change subject: frontend: node upgrade message improvement
......................................................................
Patch Set 13:
(1 comment)
tiny comment.. just convince me that length can't be larger than 4
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 676: boolean alert = false;
Line 677: // Fix hostOs[1] to be format of major.minor.build.revision
Line 678: // Add ".0" for missing parts
Line 679: String[] hostOsVersionParts = hostOs[1].split("\\.");
//$NON-NLS-1$
Line 680: for (int counter = 0; counter < 4 -
hostOsVersionParts.length; counter++) {
4 could be constant, and i would surrender it in brackets , a
s
for (int i; i < (4-len); i++)
just hope the len won't be larger than 4.. then we're screwed ..
Line 681: hostOs[1] = hostOs[1] + ".0"; //$NON-NLS-1$
Line 682: }
Line 683: Version hostVersion = new Version(hostOs[1].trim());
Line 684:
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@gmail.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
