Yair Zaslavsky has posted comments on this change.
Change subject: engine:Start Rebalance Gluster volume command
......................................................................
Patch Set 18:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
Line 26: * the status of the step and the corresponding job.
Line 27: */
Line 28:
Line 29: @NonTransactiveCommandAttribute
Line 30: @LockIdNameAttribute(isReleaseAtEndOfExecute=false)
OK, I understand the free is done from another place - GlusterTasksSyncJob
which is still WIP.
We cannot merge patches if lock is done without any unlock.
Please consider introducing the locks/unlocks at another patch, and also don't
forget to implement freeLock() as a stub method, as currrently =false in the
annotation will not prevent unlocking after execution, if you have no SPM
tasks, and this is exactly your case.
Line 31: public class StartRebalanceGlusterVolumeCommand extends
GlusterAsyncCommandBase<GlusterVolumeRebalanceParameters>{
Line 32:
Line 33:
Line 34: public
StartRebalanceGlusterVolumeCommand(GlusterVolumeRebalanceParameters params) {
--
To view, visit http://gerrit.ovirt.org/12389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaae7cf53bd77e9b717b268bcf0de91ba515af40c
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
