Sahina Bose has posted comments on this change.
Change subject: engine:Start Rebalance Gluster volume command
......................................................................
Patch Set 18:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
Line 26: * the status of the step and the corresponding job.
Line 27: */
Line 28:
Line 29: @NonTransactiveCommandAttribute
Line 30: @LockIdNameAttribute(isReleaseAtEndOfExecute=false)
Yair, the lock should not be released at end of execute of this command- it
will be released when either StopRebalanceCommand is called or when the sync
job that monitors gluster tasks determines that the task has ended.
How do you suggest this is handled, if not with "isReleaseAtEndOfExecute" ?
Line 31: public class StartRebalanceGlusterVolumeCommand extends
GlusterAsyncCommandBase<GlusterVolumeRebalanceParameters>{
Line 32:
Line 33:
Line 34: public
StartRebalanceGlusterVolumeCommand(GlusterVolumeRebalanceParameters params) {
--
To view, visit http://gerrit.ovirt.org/12389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaae7cf53bd77e9b717b268bcf0de91ba515af40c
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
