Yair Zaslavsky has posted comments on this change. Change subject: core: Database functions not fully optimized ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/dbscripts/all_disks_sp.sql Line 54: Line 55: DROP TYPE IF EXISTS disks_basic_rs CASCADE; Line 56: CREATE TYPE disks_basic_rs AS (disk_id UUID,disk_alias varchar(255),size BIGINT); Line 57: Line 58: Create or replace FUNCTION GetDisksVmGuidBasicView(v_vm_guid UUID, v_only_plugged BOOLEAN, v_user_id UUID, v_is_filtered BOOLEAN) STABLE is missing here? Line 59: RETURNS SETOF disks_basic_rs Line 60: AS $procedure$ Line 61: BEGIN Line 62: RETURN QUERY SELECT disk_id,disk_alias, size -- To view, visit http://gerrit.ovirt.org/17962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29a355286f5e6c23afe64c63efefe311c65be581 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
