Allon Mureinik has posted comments on this change. Change subject: core: Database functions not fully optimized ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/dbscripts/create_functions.sql Line 12: CREATE TYPE booleanResultType AS(result BOOLEAN); Line 13: Line 14: Line 15: CREATE OR REPLACE FUNCTION getGlobalIds(v_name VARCHAR(4000)) Line 16: RETURNS UUID IMMUTABLE STRICT is an additional modifier (regardless of IMMUTABLE/STABLE), which tells the optimizer that the function returns NULL if it was given NULL. It's an additional optimization. So, this function should have been defined as CREATE OR REPLACE FUNCTION getGlobalIds(v_name VARCHAR(4000)) RETURNS UUID IMMUTABLE STRICT See http://www.postgresql.org/docs/9.1/static/sql-createfunction.html Line 17: AS $function$ Line 18: DECLARE Line 19: v_id UUID; Line 20: BEGIN -- To view, visit http://gerrit.ovirt.org/17962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29a355286f5e6c23afe64c63efefe311c65be581 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
