Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: rename ENGINE_SSH_PUBLIC_KEY_VALUE->ENGINE_SSH_PUBLIC_KEY ......................................................................
Patch Set 1: (1 comment) .................................................... Commit Message Line 5: CommitDate: 2013-08-23 00:53:48 +0300 Line 6: Line 7: packaging: setup: rename ENGINE_SSH_PUBLIC_KEY_VALUE->ENGINE_SSH_PUBLIC_KEY Line 8: Line 9: all is values... no need to specify that within variable name. Best option for readability will probably be to access your current change and change all the others to be with suffix _FILE (e.g. OVIRT_ENGINE_PKI_ENGINE_SSH_KEY_FILE). But this will be a big and somewhat delicate change and I do not think we'll do it at this stage. When calling it '_VALUE' I wanted to emphasize that it's not a file name like the others but the key itself. I can see few options: 1. Accept this change for forget about this, creating a small ambiguity and that's all 2. The above: accept this change and also add _FILE to all the file names 3. Add some other suffix that you'll find better. E.g. _DATA, whatever. Line 10: Line 11: Change-Id: Iadb7696422583545a627aa8756773225a12904c0 -- To view, visit http://gerrit.ovirt.org/18437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadb7696422583545a627aa8756773225a12904c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
