Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: rename 
ENGINE_SSH_PUBLIC_KEY_VALUE->ENGINE_SSH_PUBLIC_KEY
......................................................................


Patch Set 1:

(1 comment)

....................................................
Commit Message
Line 5: CommitDate: 2013-08-23 00:53:48 +0300
Line 6: 
Line 7: packaging: setup: rename 
ENGINE_SSH_PUBLIC_KEY_VALUE->ENGINE_SSH_PUBLIC_KEY
Line 8: 
Line 9: all is values... no need to specify that within variable name.
Actually most aren't values but file names. E.g. 
OVIRT_ENGINE_PKI_ENGINE_SSH_KEY, OVIRT_ENGINE_PKI_APACHE_KEY, 
OVIRT_ENGINE_PKI_WEBSOCKET_PROXY_KEY.
Line 10: 
Line 11: Change-Id: Iadb7696422583545a627aa8756773225a12904c0


-- 
To view, visit http://gerrit.ovirt.org/18437
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iadb7696422583545a627aa8756773225a12904c0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to