Sahina Bose has posted comments on this change.
Change subject: gluster: Query for gluster volume rebalance status
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeTaskStatusQuery.java
Line 46: List<Step> stepsList =
DbFacade.getInstance().getStepDao().getStepsByExternalId(volume.getAsyncTask().getStepId());
Line 47: if (stepsList != null && !stepsList.isEmpty()) {
Line 48: entity.setStartTime(stepsList.get(0).getStartTime());
Line 49: }
Line 50:
Where would the formatting of values be handled? That is size in KB/MB etc, run
time is sec/hours/days etc?
Maybe the entity can provide a method to get this? For instance,
getFormattedFileSize() that returns a String?
Line 51: return entity;
Line 52: }
--
To view, visit http://gerrit.ovirt.org/18352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3704f750fafcf3546c5237a4dde67b5f85a691e4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
