Kanagaraj M has posted comments on this change.

Change subject: gluster: Query for gluster volume rebalance status
......................................................................


Patch Set 10:

(2 comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java
Line 39:     private GlusterVolumeTaskStatusEntity fetchTaskStatusDetails() {
Line 40:         VDSReturnValue returnValue =
Line 41:                 
runVdsCommand(VDSCommandType.GetGlusterVolumeRebalanceStatus,
Line 42:                         new 
GlusterVolumeVDSParameters(getUpServerId(clusterId), volume.getName()));
Line 43: 
What if there are no up servers in the cluster?
Line 44:         // Set the volume re-balance start time
Line 45:         GlusterVolumeTaskStatusEntity entity = 
(GlusterVolumeTaskStatusEntity)returnValue.getReturnValue();
Line 46:         List<Step> stepsList = 
DbFacade.getInstance().getStepDao().getStepsByExternalId(volume.getAsyncTask().getStepId());
Line 47:         if (stepsList != null && !stepsList.isEmpty()) {


....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 281:     GLUSTER_VOLUME_OPTIONS_RESET_ALL(4074),
Line 282:     GLUSTER_HOST_UUID_NOT_FOUND(4075),
Line 283:     GLUSTER_VOLUME_BRICK_ADDED(4076),
Line 284:     GLUSTER_CLUSTER_SERVICE_STATUS_ADDED(4077),
Line 285:     GLUSTER_VOLUME_TASK_STATUS_FAILED(4078),
Is this being used?
Line 286: 
Line 287:     USER_FORCE_SELECTED_SPM(159),
Line 288:     USER_VDS_RESTART(41),
Line 289:     USER_FAILED_VDS_RESTART(107),


-- 
To view, visit http://gerrit.ovirt.org/18352
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3704f750fafcf3546c5237a4dde67b5f85a691e4
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to