Moti Asayag has posted comments on this change.
Change subject: webadmin: Changed units of Network QoS in UI
......................................................................
Patch Set 1:
(4 comments)
....................................................
Commit Message
Line 6:
Line 7: webadmin: Changed units of Network QoS in UI
Line 8:
Line 9: Network QoS 'Burst' property is commonly counted in Megabytes and not
Line 10: Megabits. vdsm API also recives this vlaue in Megabytes.
s/vlaue/value
Line 11:
Line 12: UI was changed (label) to support this convention and tooltip added to
Line 13: point the difference between 'Burst' and 'Average' and 'Peak' fields.
Line 14:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 3042:
Line 3043: @DefaultStringValue("Burst")
Line 3044: String burstNetworkQoSPopup();
Line 3045:
Line 3046: @DefaultStringValue("(Mega-bits per second)")
why there is a need for a dash? why not just Megabits ?
Line 3047: String inMegabitsNetworkQoSPopup();
Line 3048:
Line 3049: @DefaultStringValue("(Mega-Bytes)")
Line 3050: String inMegabytesNetworkQoSPopup();
Line 3045:
Line 3046: @DefaultStringValue("(Mega-bits per second)")
Line 3047: String inMegabitsNetworkQoSPopup();
Line 3048:
Line 3049: @DefaultStringValue("(Mega-Bytes)")
same here, maybe just Megabytes ?
Line 3050: String inMegabytesNetworkQoSPopup();
Line 3051:
Line 3052: @DefaultStringValue("Inbound")
Line 3053: String inboundLabelQoSPopup();
Line 3057:
Line 3058: @DefaultStringValue("Mbps")
Line 3059: String mbpsLabelQoSPopup();
Line 3060:
Line 3061: @DefaultStringValue("MiB")
I think it should be Mb, see [1]
"The megabit has the unit symbol Mb or Mbit."
[1] http://en.wikipedia.org/wiki/Megabit
Line 3062: String mbLabelQoSPopup();
Line 3063:
Line 3064: @DefaultStringValue("Cluster Policies")
Line 3065: String configureClusterPolicyTabLabel();
--
To view, visit http://gerrit.ovirt.org/18395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dd2367b136d547f7f93fdc8a1b76561920ce59a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
