ofri masad has uploaded a new change for review. Change subject: webadmin: Changed units of Network QoS in UI ......................................................................
webadmin: Changed units of Network QoS in UI Network QoS 'Burst' property is commonly counted in Megabytes and not Megabits. vdsm API also recives this vlaue in Megabytes. UI was changed (label) to support this convention and tooltip added to point the difference between 'Burst' and 'Average' and 'Peak' fields. Change-Id: I1dd2367b136d547f7f93fdc8a1b76561920ce59a Bug-Url: https://bugzilla.redhat.com/999799 Signed-off-by: Ofri Masad <oma...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java 2 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/95/18395/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java index a1510ca..a35c4b4 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java @@ -3043,6 +3043,12 @@ @DefaultStringValue("Burst") String burstNetworkQoSPopup(); + @DefaultStringValue("(Mega-bits per second)") + String inMegabitsNetworkQoSPopup(); + + @DefaultStringValue("(Mega-Bytes)") + String inMegabytesNetworkQoSPopup(); + @DefaultStringValue("Inbound") String inboundLabelQoSPopup(); @@ -3052,7 +3058,7 @@ @DefaultStringValue("Mbps") String mbpsLabelQoSPopup(); - @DefaultStringValue("Mb") + @DefaultStringValue("MiB") String mbLabelQoSPopup(); @DefaultStringValue("Cluster Policies") diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java index 35aee27..6047b30 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java @@ -136,6 +136,12 @@ outboundBurstEditor.setLabel(constants.burstNetworkQoSPopup()); inboundEnabled.setLabel(constants.inboundLabelQoSPopup()); outboundEnabled.setLabel(constants.outboundLabelQoSPopup()); + inboundAverageEditor.setTitle(constants.averageNetworkQoSPopup() + constants.inMegabitsNetworkQoSPopup()); + inboundPeakEditor.setTitle(constants.peakNetworkQoSPopup() + constants.inMegabitsNetworkQoSPopup()); + inboundBurstEditor.setTitle(constants.burstNetworkQoSPopup() + constants.inMegabytesNetworkQoSPopup()); + outboundAverageEditor.setTitle(constants.averageNetworkQoSPopup() + constants.inMegabitsNetworkQoSPopup()); + outboundPeakEditor.setTitle(constants.peakNetworkQoSPopup() + constants.inMegabitsNetworkQoSPopup()); + outboundBurstEditor.setTitle(constants.burstNetworkQoSPopup() + constants.inMegabytesNetworkQoSPopup()); } @Override -- To view, visit http://gerrit.ovirt.org/18395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1dd2367b136d547f7f93fdc8a1b76561920ce59a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
