Einav Cohen has posted comments on this change. Change subject: UI: expose CSS class defined in LoginPopupView.ui.xml ......................................................................
Patch Set 4: just a general note - please keep in mind that we should expose brandable styles for the elements that it makes sense to brand [e.g. general theme colors (not every single color in the application), top banner image, etc.] I am not sure if it makes sense to externalize the rather-neutral style of the locale-drop-down in the login page, for example. Also need to keep in mind that specifically in GWT, externalizing resources can affect the performance/behavior of the application. Therefore - please think *carefully* on your exact branding needs and which styles it actually makes sense to externalize. Thanks. -- To view, visit http://gerrit.ovirt.org/18156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80dcacf8d62f9bb051747e530f0d24e692388ce7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: 静 黎 <mobi...@gmail.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: 静 黎 <mobi...@gmail.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
