Kanagaraj M has posted comments on this change.
Change subject: Web - admin : Added a drop down menu for rebalance Added a
drop down menu for rebalance Change-Id:
Idf8e3478abaace95adc2a565cb3e7c95dd0e7780 Signed-off-by: Anmol Babu
<anb...@redhat.com>
......................................................................
Patch Set 3:
(4 comments)
....................................................
Commit Message
Line 6:
Line 7: Web - admin : Added a drop down menu for rebalance
Line 8: Added a drop down menu for rebalance
Line 9: Change-Id: Idf8e3478abaace95adc2a565cb3e7c95dd0e7780
Line 10: Signed-off-by: Anmol Babu <anb...@redhat.com>
Please address earlier comments.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 130: setCreateVolumeCommand(new UICommand("Create Volume", this));
//$NON-NLS-1$
Line 131: setRemoveVolumeCommand(new UICommand("Remove", this));
//$NON-NLS-1$
Line 132: setStartCommand(new UICommand("Start", this)); //$NON-NLS-1$
Line 133: setStopCommand(new UICommand("Stop", this)); //$NON-NLS-1$
Line 134: setStartRebalanceCommand(new UICommand("Rebalance", this));
//$NON-NLS-1$
change to "StartRebalance" here as well.
Line 135: setOptimizeForVirtStoreCommand(new
UICommand("OptimizeForVirtStore", this)); //$NON-NLS-1$
Line 136: getStartRebalanceCommand().setIsAvailable(true);
Line 137:
Line 138: getRemoveVolumeCommand().setIsExecutionAllowed(false);
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
Line 152: return
getMainModel().getOptimizeForVirtStoreCommand();
Line 153: }
Line 154: });
Line 155: List<ActionButtonDefinition<GlusterVolumeEntity>>
rebalanceSubctions = new
LinkedList<ActionButtonDefinition<GlusterVolumeEntity>>();
Line 156: rebalanceSubctions.add(new
WebAdminButtonDefinition<GlusterVolumeEntity>(constants.startRebalance()) {
i think rebalanceSubctions is misspelled, can you correct it?
Line 157: @Override
Line 158: protected UICommand resolveCommand() {
Line 159: return getMainModel().getStartRebalanceCommand();
Line 160: }
Line 159: return getMainModel().getStartRebalanceCommand();
Line 160: }
Line 161: });
Line 162:
Line 163: getTable().addActionButton(new
WebAdminMenuBarButtonDefinition<GlusterVolumeEntity>(constants.rebalanceVolume(),rebalanceSubctions,CommandLocation.ContextAndToolBar));
Again, why should be only in Toolbar?
Line 164: }
--
To view, visit http://gerrit.ovirt.org/18298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf8e3478abaace95adc2a565cb3e7c95dd0e7780
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
