Kanagaraj M has posted comments on this change. Change subject: Web - admin : Added a drop down menu for rebalance Added a drop down menu for rebalance Change-Id: Idf8e3478abaace95adc2a565cb3e7c95dd0e7780 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Anmol Babu <anb...@redhat.com> ......................................................................
Patch Set 1: (6 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-08-20 13:00:01 +0530 Line 4: Commit: Anmol Babu <anb...@redhat.com> Line 5: CommitDate: 2013-08-20 13:00:12 +0530 Line 6: Line 7: Web - admin : Added a drop down menu for rebalance Please change the commit message header to "webadmin : added volume rebalance start action" Line 8: Added a drop down menu for rebalance Line 9: Change-Id: Idf8e3478abaace95adc2a565cb3e7c95dd0e7780 Line 10: Bug-Url: https://bugzilla.redhat.com/?????? Line 4: Commit: Anmol Babu <anb...@redhat.com> Line 5: CommitDate: 2013-08-20 13:00:12 +0530 Line 6: Line 7: Web - admin : Added a drop down menu for rebalance Line 8: Added a drop down menu for rebalance Also please insert a new-line between commit header, message and Change-Id for better readability. Line 9: Change-Id: Idf8e3478abaace95adc2a565cb3e7c95dd0e7780 Line 10: Bug-Url: https://bugzilla.redhat.com/?????? Line 6: Line 7: Web - admin : Added a drop down menu for rebalance Line 8: Added a drop down menu for rebalance Line 9: Change-Id: Idf8e3478abaace95adc2a565cb3e7c95dd0e7780 Line 10: Bug-Url: https://bugzilla.redhat.com/?????? Don't include the Bug-Url if this patch is doen't have fix for a bug .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java Line 132: setStartCommand(new UICommand("Start", this)); //$NON-NLS-1$ Line 133: setStopCommand(new UICommand("Stop", this)); //$NON-NLS-1$ Line 134: setRebalanceCommand(new UICommand("Rebalance", this)); //$NON-NLS-1$ Line 135: setOptimizeForVirtStoreCommand(new UICommand("OptimizeForVirtStore", this)); //$NON-NLS-1$ Line 136: getRebalanceCommand().setIsAvailable(true); Please change the command name to "StartRebalanceCommand" Line 137: Line 138: getRemoveVolumeCommand().setIsExecutionAllowed(false); Line 139: getStartCommand().setIsExecutionAllowed(false); Line 140: getStopCommand().setIsExecutionAllowed(false); .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java Line 171: @Override Line 172: protected UICommand resolveCommand() { Line 173: return null; Line 174: } Line 175: }); Please removed this code Line 176: */ Line 177: getTable().addActionButton(new WebAdminMenuBarButtonDefinition<GlusterVolumeEntity>(constants.rebalanceVolume(),rebalanceSubctions,CommandLocation.OnlyFromToolBar)); Line 178: } Line 173: return null; Line 174: } Line 175: }); Line 176: */ Line 177: getTable().addActionButton(new WebAdminMenuBarButtonDefinition<GlusterVolumeEntity>(constants.rebalanceVolume(),rebalanceSubctions,CommandLocation.OnlyFromToolBar)); Why this should available only in the toolbar not in the context menu(right-click)? Line 178: } -- To view, visit http://gerrit.ovirt.org/18298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf8e3478abaace95adc2a565cb3e7c95dd0e7780 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
