Alissa Bonas has posted comments on this change.
Change subject: core: sync luns info after ConnectStorageServer
......................................................................
Patch Set 7:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommandTest.java
Line 22: private
SyncLunsInfoForIscsiStorageDomainCommand<StorageDomainParametersBase> command;
Line 23: private StorageDomainParametersBase parameters;
Line 24:
Line 25: @Before
Line 26: public void setup() {
there's no need because of @Before of junit4. actually I would go further and
call it init, but I don't think it's worth to touch the patch just for that.
Line 27: parameters = new StorageDomainParametersBase(Guid.newGuid());
Line 28: parameters.setVdsId(Guid.newGuid());
Line 29:
Line 30: command = spy(new
SyncLunsInfoForIscsiStorageDomainCommand<StorageDomainParametersBase>(parameters));
Line 54: List<LUNs> lunsFromVgInfo =
Collections.singletonList(lunFromVG);
Line 55: List<LUNs> lunsFromDb = Collections.singletonList(lunFromDB);
Line 56:
Line 57: boolean isMismatch =
command.isLunsInfoMismatch(lunsFromVgInfo, lunsFromDb);
Line 58: assertTrue(isMismatch);
the method is self explanatory. the value was supposed to be true, but it
wasn't. I don't see the need in further explanations.
Line 59: }
Line 60:
Line 61: @Test
Line 62: public void lunsMatch() {
--
To view, visit http://gerrit.ovirt.org/17919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5867ad8d36f329e23c611079512be30a9c5f83a5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
