Allon Mureinik has posted comments on this change.
Change subject: core: sync luns info after ConnectStorageServer
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommandTest.java
Line 22: private
SyncLunsInfoForIscsiStorageDomainCommand<StorageDomainParametersBase> command;
Line 23: private StorageDomainParametersBase parameters;
Line 24:
Line 25: @Before
Line 26: public void setup() {
I know how @Before works :-)
setup() is a horrible name - it invokes all sorts of false
FindBugs/checkstyle/coverity/mureinik alarms.
If you want to be consistent with JUnit 3 standards (which is a fair approach)
- call it setUp().
If you do not (which is also a fair approach) - call it init() or before(), or
even better, something meaningful like spyCommand().
Line 27: parameters = new StorageDomainParametersBase(Guid.newGuid());
Line 28: parameters.setVdsId(Guid.newGuid());
Line 29:
Line 30: command = spy(new
SyncLunsInfoForIscsiStorageDomainCommand<StorageDomainParametersBase>(parameters));
--
To view, visit http://gerrit.ovirt.org/17919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5867ad8d36f329e23c611079512be30a9c5f83a5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
