Alex Lourie has posted comments on this change.
Change subject: packaging: setup: text changes
......................................................................
Patch Set 3:
(4 comments)
Few small comments.
....................................................
File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py
Line 332: default=True,
Line 333: )
Line 334:
Line 335: if self.environment[osetupcons.RPMDistroEnv.ENABLE_UPGRADE]:
Line 336: self.logger.info(_('Checking for an update for Setup...'))
Setup -> setup package
Line 337: if self._checkForPackagesUpdate(
Line 338: packages=(osetupcons.Const.ENGINE_PACKAGE_SETUP_NAME,)
Line 339: ):
Line 340: self.logger.error(
Line 338: packages=(osetupcons.Const.ENGINE_PACKAGE_SETUP_NAME,)
Line 339: ):
Line 340: self.logger.error(
Line 341: _(
Line 342: 'An update for the Setup package "{package}"
was '
why Setup capitalized?
Line 343: 'found. Please update that package, e.g. by
running '
Line 344: '"yum update {package}", and then execute
Setup again.'
Line 345: ).format(
Line 346:
package=osetupcons.Const.ENGINE_PACKAGE_SETUP_NAME,
Line 340: self.logger.error(
Line 341: _(
Line 342: 'An update for the Setup package "{package}"
was '
Line 343: 'found. Please update that package, e.g. by
running '
Line 344: '"yum update {package}", and then execute
Setup again.'
same
Line 345: ).format(
Line 346:
package=osetupcons.Const.ENGINE_PACKAGE_SETUP_NAME,
Line 347: )
Line 348: )
Line 368:
name='OVESETUP_RPMDISTRO_REQUIRE_ROLLBACK',
Line 369: note=_(
Line 370: 'Setup will not be able to rollback
new '
Line 371: 'packages in case of a failure
because '
Line 372: 'existing ones are missing at the
repository. '
Suggestion:
'...because installed ones are missing the available repositories.'
Line 373: 'Do you want to continue anyway? '
Line 374: '(@VALUES@) [@DEFAULT@]: '
Line 375: ),
Line 376: prompt=True,
--
To view, visit http://gerrit.ovirt.org/18053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a50fdb2e3b2281fafa894b8e95c7902ba24380
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
