Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: text changes
......................................................................


Patch Set 1:

(2 comments)

....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 939: 
Line 940:     @osetupattrs(
Line 941:         answerfile=True,
Line 942:         summary=True,
Line 943:         description=_('Set application as root page'),
I searched the web and found no conclusive summary. I personally do not like 
these, but neither do I like very much 'root'. Changed to 'default'.
Line 944:         postinstallfile=True,
Line 945:     )
Line 946:     def CONFIGURE_ROOT_REDIRECTION(self):
Line 947:         return 'OVESETUP_APACHE/configureRootRedirection'


....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/nfs.py
Line 119:                 self._enabled = dialog.queryBoolean(
Line 120:                     dialog=self.dialog,
Line 121:                     name='NFS_CONFIG_ENABLED',
Line 122:                     note=_(
Line 123:                         'Configure an NFS share on this server to be 
used '
If you pronounce it, when speaking, 'an en ef ess share', then 'an'. Although 
you can easily find conflicting opinions on the web, notably microsoft's style 
guide.
Line 124:                         'as an ISO Domain? '
Line 125:                         '(@VALUES@) [@DEFAULT@]: '
Line 126:                     ),
Line 127:                     prompt=True,


-- 
To view, visit http://gerrit.ovirt.org/18053
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a50fdb2e3b2281fafa894b8e95c7902ba24380
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to