Ori Liel has posted comments on this change. Change subject: Use FQDN from guest agent for RDP ......................................................................
Patch Set 8: (1 comment) See one comment of mine in Patch-Set 8 .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 2296: Line 2297: <xs:complexType name="GuestInfo"> Line 2298: <xs:sequence> Line 2299: <xs:element ref="ips" minOccurs="0" maxOccurs="1"/> Line 2300: <xs:element name="fqdn" type="xs:string" minOccurs="0" maxOccurs="1"/> IIUC, RdpUseFqdnIfAvailable is a configuration option in VDC_OPTIONS table. If so, I think the right way to expose it is by granting user access to the contents of VDC_OPTIONS via the API - something that we're working on and is out of the scope of this patch. But just to fully understand, what did you mean by: "It's only in the frontend code where the decision is made if it should use FQDN or an IP"? The API is more inclusive than the GUI, and any configuration that can be made by the GUI should in principle be avaliable through the API. This is not true the other way around, by the way (meaning API may contain functionality which the GUI does not). Line 2301: </xs:sequence> Line 2302: </xs:complexType> Line 2303: Line 2304: <xs:element name="vms" type="VMs"/> -- To view, visit http://gerrit.ovirt.org/17709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
