Omer Frenkel has posted comments on this change.
Change subject: Use FQDN from guest agent for RDP
......................................................................
Patch Set 10:
(4 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1498: ExternalSchedulerEnabled(534),
Line 1499:
Line 1500: @TypeConverterAttribute(Boolean.class)
Line 1501: @DefaultValueAttribute("true")
Line 1502: RdpUseFqdnIfAvailable(535),
maybe call it UseFqdnForRdpIfAvailable
i think it sounds better
Line 1503:
Line 1504: Invalid(65535);
Line 1505:
Line 1506: private int intValue;
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDAOTest.java
Line 118: public void testUpdateAll() throws Exception {
Line 119: VmDynamic existingVm2 = dao.get(new
Guid("77296e00-0cad-4e5a-9299-008a7b6f4356"));
Line 120: existingVm.setStatus(VMStatus.Down);
Line 121: existingVm2.setVmIp("111");
Line 122: existingVm2.setVmFQDN("localhost.localdomain");
you need to update also fixtures.xml file with the new field
Line 123:
Line 124: dao.updateAll(Arrays.asList(new VmDynamic[] { existingVm,
existingVm2 }));
Line 125:
Line 126: assertEquals(existingVm, dao.get(existingVm.getId()));
....................................................
File packaging/dbscripts/create_views.sql
Line 579: WHERE vm_static.entity_type = 'VM';
Line 580:
Line 581:
Line 582:
Line 583: CREATE OR REPLACE VIEW vms_with_tags
i think it should be added here as well
Line 584: AS
Line 585: SELECT vms.vm_name, vms.vm_mem_size_mb, vms.nice_level,
vms.cpu_shares, vms.vmt_guid, vms.vm_os, vms.vm_description, vms.vm_comment,
Line 586: vms.vds_group_id, vms.vm_domain, vms.vm_creation_date,
vms.auto_startup, vms.is_stateless, vms.is_smartcard_enabled,
vms.is_delete_protected,
Line 587: vms.dedicated_vm_for_vds, vms.fail_back,
vms.default_boot_sequence, vms.vm_type,
....................................................
File packaging/dbscripts/vms_sp.sql
Line 245: v_is_run_once BOOLEAN)
Line 246: RETURNS VOID
Line 247: AS $procedure$
Line 248: BEGIN
Line 249: INSERT INTO vm_dynamic(app_list, guest_cur_user_name,
console_cur_user_name, guest_last_login_time, guest_last_logout_time,
console_user_id, guest_os, migrating_to_vds, RUN_ON_VDS, status, vm_guid,
vm_host, vm_ip, last_start_time, vm_pid, display, acpi_enable, session,
display_ip, display_type, kvm_enable, boot_sequence, display_secure_port,
utc_diff, last_vds_run_on, client_ip, guest_requested_memory,
hibernation_vol_handle,exit_status,pause_status,exit_message,
guest_agent_nics_hash, last_watchdog_event, last_watchdog_action, is_run_once)
missing column name here
Line 250: VALUES(v_app_list, v_guest_cur_user_name,
v_console_cur_user_name, v_guest_last_login_time, v_guest_last_logout_time,
v_console_user_id, v_guest_os, v_migrating_to_vds, v_run_on_vds, v_status,
v_vm_guid, v_vm_host, v_vm_ip, v_last_start_time, v_vm_pid, v_display,
v_acpi_enable, v_session, v_display_ip, v_display_type, v_kvm_enable,
v_boot_sequence, v_display_secure_port, v_utc_diff, v_last_vds_run_on,
v_client_ip, v_guest_requested_memory, v_hibernation_vol_handle, v_exit_status,
v_pause_status, v_exit_message, v_guest_agent_nics_hash, v_last_watchdog_event,
v_last_watchdog_action, v_is_run_once, v_vm_fqdn);
Line 251: END; $procedure$
Line 252: LANGUAGE plpgsql;
Line 253:
--
To view, visit http://gerrit.ovirt.org/17709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
