Michael Pasternak has posted comments on this change. Change subject: packaging: disconnecting api instance at the end of all in one ......................................................................
Patch Set 1: >> alon, my intention is to help, not to make life harder, i'm in same boat >> with you, and truly want to help as much as i can > > You got this backwards... I am trying to help make the sdk better, and follow > the convention that are expected for the sake of other users. > > we are using two variables, each plugin use its own, the are not aware of the > other. this is not the scenario described in the bug, the reproducer uses very same variable engine_api for all new instances of sdk proxy, when you using different variables for the different instances you do not have to disconnect them..., this is true only for reusing old variable for the new instance. -- To view, visit http://gerrit.ovirt.org/17847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ece6bb8f825606442322a087fd52a647af64ffe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
