Michael Pasternak has posted comments on this change.
Change subject: packaging: disconnecting api instance at the end of all in one
......................................................................
Patch Set 1:
Alon,
>> can you please explain why?
>
> again... we have two plugins that work without knowing each other. each open
> API channel for its own use. use can be at specific phase or multiple phases.
>
> the fact that the sdk does not allow many instances to
> work in parallel constructed/destructed/kept should be
> fixed
it does allow that, it just asks to release remote resources
when you using same variable for the new instance that's all
(btw when)
>and not introduce complexity into the implementation of
>the user.
alon, my intention is to help, not to make life harder, i'm
in same boat with you, and truly want to help as much as i
can
but please try to understand, we have a real life scenario where we have to
release resources on the server side, and
the way to do that is calling disconnect() method, if you
have better ideas, i'm open.
the right way for reusing same engine_api variable will be:
def createSdk(**kwargs)
if self.engine_api:
self.engine_api.disconnect()
return self.engine_api(**kwargs)
or just create SDK in new variable.
--
To view, visit http://gerrit.ovirt.org/17847
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ece6bb8f825606442322a087fd52a647af64ffe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
